Re: [Nano-devel] [PATCH] bright colors without bold

[Brand Huntsman]

On Fri, 9 Feb 2018 11:31:33 +0100
Benno Schulenberg <address@hidden> wrote:

> Op 08-02-18 om 03:04 schreef Brand Huntsman:
> >     if (strncasecmp(colorname, "bright", 6) == 0) {
> > +           /* The bright foreground prefix makes the color
> > bright without
> > +            * bolding it.  It bolds on terminals with only 8
> > colors. */  
> 
> The second sentence isn't true.

It is true, parse_color_names() sets A_BOLD if fg_bright and nr_term_colors == 
8.


> The "(bold,)*" should be "(bold,)?".

Yes.


> Amended patches are coming up.
> +           if (nr_term_colors == 8)
> +               *attributes |= A_BOLD;
> +           else
> +               *fg += 8;

That should be the way I had it so nr_term_colors==0 doesn't add 8 and make the 
text invisible.