[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] Implement incremental search
From: |
Benno Schulenberg |
Subject: |
Re: [Nano-devel] [PATCH] Implement incremental search |
Date: |
Sun, 11 Feb 2018 12:19:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
Op 10-02-18 om 15:25 schreef Marco Diego Aurélio Mesquita:
I tested your patch and could not run into any problem. So, if you want, I
suggest you to apply it.
Well, for that several people will have to say that they want this feature.
And even then, I'm still not sure. I like it that the match gets highlighted
(just putting the cursor on the first character of the match, as is done
in a normal search, is quite poor), but I don't like it that the screen
"jumps around" while I type the search string... Also, is there anything
you can do with incremental search that you can't do with a normal search?
Does it add anything other than a different behavior?
A patch with both changes integrated and rebased to current master is
attached.
Good. But the patch is still lacking a commit message. Explain in a few
sentences what your patch does and how it accomplishes that.
Benno