Re: [Nano-devel] [PATCH] index/RGB colors and italic/reverse/underline attributes

[Benno Schulenberg]

Op 15-02-18 om 23:57 schreef Brand Huntsman:
> +             prev_index = index+1;

Always spaces around operators.  (Several other places as well.)

> +             unsigned char g_shades[4] = {0, 68, 176, 255};
> +                     /* black - 13% / 35% / 36% / 16% - white */
> +
> +             unsigned char c_shades[5] = {0, 51, 127, 204, 255};
> +                     /* dark - 10% / 25% / 30% / 25% / 10% - bright */

I don't understand these comments.  How do the percentages relate to the
numbers?

> +static int hex2int(char c)

Each function needs an introductory comment.


Testing...

When I put this in my nanorc (index 23 is a dark cyanish color on my terminal):

  set selectedcolor brightwhite,23

nano responds with:

Error in /home/ben/.nanorc on line 170: A background color cannot be bright

Benno

signature.asc
Description: OpenPGP digital signature