[Nano-devel] Fwd: Future of incremental search

[Marco Diego Aurélio Mesquita]

---------- Forwarded message ----------
From: Marco Diego Aurélio Mesquita <address@hidden>
Date: Fri, Feb 23, 2018 at 3:05 PM
Subject: Re: [Nano-devel] Future of incremental search
To: Brand Huntsman <address@hidden>


The attached patch is not intended for inclusion. I'm sending it so
interested can try its behaviour. It should apply to
dd9766c2e025c2df934ae5b8efb934581599e6fd .

On Tue, Feb 20, 2018 at 6:29 PM, Brand Huntsman <address@hidden> wrote:
> How hard would it be to put NOT FOUND or BAD REGEX message on far right, like 
> how Modified is in titlebar? It would keep the query from from shifting right 
> and left as your type a regex. And when errorcolor is supported, only color 
> the BAD REGEX with errorcolor, to avoid the prompt flashing while typing a 
> regex. When query isn't found the entire prompt or just the NOT FOUND could 
> be highlighted with errorcolor, but maybe just the NOT FOUND.
>
>

Done on the attached patch.

>> > I can open the inc-search prompt and press enter to search for
>> > previous match but that match no longer shows up in the prompt.
>>
>> This was a bad behaviour non intentionally implemented on the latest
>> iteration. When <Enter> is pressed on an empty prompt, no search
>> should be done. The old behaviour has been restored on the attached
>> patch.
>
> Why not make it behave like normal search?
>

Benno convinced me that an empty prompt while in incremental search
should do nothing. I agreed with him.

>> > The delay you implemented is terrible, it makes search more laggy
>> > than before. I paste a 90 character line and it takes 2 seconds
>>
>> Fixed on the attached patch.
>
> Works fast.
>
> But pasting a line with a linefeed no longer works.
>
>

Is it a deal breaker? Do you think the behaviour of the attached patch
is acceptable?

diff.patch
Description: Text Data