[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] Erase next word if ctrl is held when delete is
Re: [Nano-devel] [PATCH] Erase next word if ctrl is held when delete is pressed
Tue, 17 Jul 2018 20:28:04 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
Op 16-07-18 om 23:32 schreef Marco Diego Aurélio Mesquita:
> Subject: [PATCH] Erase next word if ctrl is held when pressing delete.
> Signed-off-by: Marco Diego Aurélio Mesquita <address@hidden>
The subject line should start with "input: ", and the phrase should
not start with a capital and not end with a period.
After a blank line, the commit message could say that this now binds
by default the until-now unbound function 'cutwordright'. And that
the other function, 'cutwordleft', cannot be bound to Ctrl+Backspace
as that keystroke often generates ^H, which does a plain backspace.
> -int controlleft, controlright, controlup, controldown, controlhome,
> +int controlleft, controlright, controlup, controldown;
There was no need to change this line. So don't.
> + add_to_sclist(MMAIN, "^Del", CONTROL_DEL, do_cut_next_word, 0);
This fails to compile with --enable-tiny.
For the rest, the patch looks good.
For me, it works on an Xfce-terminal, on an xterm, and on urxvt. But
it works on none of them when using option -K: "Unknown sequence".
Also, it does not work at all on a Linux console. You need to add an
'if' around line 610 in src/winio.c
Description: OpenPGP digital signature