[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] display: first attempt at making --nohelp effec

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] display: first attempt at making --nohelp effective only in main menu
Date: Sun, 26 Aug 2018 12:17:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Op 24-08-18 om 15:35 schreef Brand Huntsman:
> On Thu, 23 Aug 2018 20:40:53 +0200
> Benno Schulenberg <address@hidden> wrote:
>> A major problem is that when cancelling a search (for example), then
>> the "Cancelled" message gets written while the two help lines are
>> still there, but then the edit window gets rewritten without those
>> two lines, meaning that the status bar and the message get plastered
>> over.  :| I don't know how to fix that.
> The attached patch works for that case and might work for all.

Thanks for the patch.  It does work.  But I was already discontent with
my own patch.  First because it is wasteful: it redraws the entire edit
window whereas only its two bottom lines need to be drawn (of course
ncurses will not actually send anything to the terminal for those other
lines, because nothing changed there, but still, nano churns for nought).
And second, on a Linux console the first writing of "Cancelled" flashes
on the higher status bar, which is annoying.

The problem is that nano defines the edit area and the status/help area
as two separate subwindows, which makes switching between different sizes
expensive.  To make it cheap, they would have to be a single subwindow.
But that is too big a change to even contemplate for now.

> Line 64 in your patch has a space between tabs in the indent.

Thanks.  (It was highlighted but still I overlooked it.)


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]