Re: [PATCH] Fix an rcfile out-of-bounds read on empty lines

[Benno Schulenberg]

Op 16-02-2020 om 13:12 schreef Saagar Jha:
> This is just a minor out-of-bounds fix in parse_rcfile.
> 
> [...]
>               /* Strip the terminating newline and possibly a carriage 
> return. */
> -             if (buffer[length - 1] == '\n')
> +             if (length && buffer[length - 1] == '\n')
>                       buffer[--length] = '\0';
> -             if (buffer[length - 1] == '\r')
> +             if (length && buffer[length - 1] == '\r')
>                       buffer[--length] = '\0';

Thanks for noticing this.  However... only half of it is needed: the
while loop starts with the equivalent of 'length > 0'.

Also, when posting a patch, please add a Signed-off-by line.  See the
last section in the README.GIT file.

Benno

signature.asc
Description: OpenPGP digital signature