[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: having a scroll bar also in softwrap mode
|
From: |
Benno Schulenberg |
|
Subject: |
Re: having a scroll bar also in softwrap mode |
|
Date: |
Wed, 29 Apr 2020 12:34:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
Op 29-04-2020 om 03:54 schreef Marco Diego Aurélio Mesquita:
> This is probably caused because the renumbering is only triggered when
> there is a change on a softwrapped line. What really is needed is a
> way to detect if the number of softwrapped lines has (chunks) has
> changed.
That detection is already there: see in inject() and do_deletion().
(First do a git pull and a rebase.)
>> Poor naming of a variable: I hardly see a difference with lineno.
>
> How about logical_lineno?
How about chunk_nr? Then it's clear what it counts.
>> Comment does not fit the code. :/
>
> Easy to fix.
Yes. But it is sloppy that it wasn't correct in the first place.
When you *do* add a comment, make sure it's correct. Otherwise,
just them leave out. Wrong is worse than none.
Benno
signature.asc
Description: OpenPGP digital signature