[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] files: improve the backup procedure to ensure no data is
From: |
Benno Schulenberg |
Subject: |
Re: [PATCH v2] files: improve the backup procedure to ensure no data is lost |
Date: |
Wed, 8 Jul 2020 19:12:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
Op 07-07-2020 om 11:54 schreef Michalis Kokologiannakis:
> Indeed, I had noticed these issues, but I thought to send fixes for them as
> separate patches. But I think you are right for the former one; it would be
> better to incorporate it into this one.
>
> Thoughts on the attached?
Thanks. Looks good. Will apply it to master tomorrow.
I will drop the references to the other two bugs (that I added) because
the patch doesn't prevent that the original file remains truncated when
the target device is full and under concurrent writing pressure.
(The patch just reduces the severity of such a truncation because nano
will have saved a copy of the original file to the user's home directory.
But that will be a small consolation when the file is some configuration
file that must be there for some system to function.)
Benno
signature.asc
Description: OpenPGP digital signature