nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix C/C++ syntax highlighting of '#include <...>'


From: Hussam al-Homsi
Subject: Re: [PATCH] Fix C/C++ syntax highlighting of '#include <...>'
Date: Sun, 25 Apr 2021 17:31:12 -0400

On Sun, Apr 25, 2021 at 6:19 AM Benno Schulenberg <bensberg@telfort.nl> wrote:
>
>
> Op 24-04-2021 om 07:43 schreef Hussam al-Homsi:
> > The attached patch consists of 3 tiny changes listed in the commit message.
> > Change 1 follows the "Source file inclusion" section of the C/C++
> > standards while changes 2 and 3 follow the "Header names" section.
>
> When you're referring to the standards, please provide URLs to the
> relevant sections, preferably in the commit message itself.

At first I thought that would get messy but it's more complete so I'll do it.

> > Subject: [PATCH] Fix C/C++ syntax highlighting of '#include <...>'
>
> Please use the header-line style that nano used: "syntax: c: .....".

I'll keep that in mind.

> > 1. Zero or more spaces can occur between 'include' and '<...>'.
>
> To describe the change better, I would say: "The number of spaces
> ..... may be zero."
>
> > 2. Blanks and '=' can occur inside '<...>' but '>' cannot.
> > 3. One or more characters can occur inside '<...>'.
>
> "There must be at least one character...."

I've attached a modified patch that integrates your suggestions.

Attachment: 0001-syntax-c-fix-highlighting-of-include.patch
Description: Source code patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]