[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tweaks: change "return ++auto_var; " to "return auto_var + 1

From: Benno Schulenberg
Subject: Re: [PATCH] tweaks: change "return ++auto_var; " to "return auto_var + 1; "
Date: Sat, 2 Oct 2021 17:44:03 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

Op 02-10-2021 om 08:21 schreef Hussam al-Homsi:
> Subject: [PATCH] tweaks: change "return ++auto_var;" to "return auto_var + 1;"
> This avoids an unused and misleading assignment that makes one
> think the incremented automatic variable will be used again.

Hmm.  It doesn't make me think the variable will be used again, because
it clearly says 'return', and they are both local variables.

Anyway, applied, to humor you.  But this is the last time.  Please don't
bother me with matters of style -- as long as things work correctly and
there is no compiler that complains, then all is fine.  Consider sending
patches that fix actual bugs instead.


Attachment: OpenPGP_signature
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]