netutils-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Netutils-dev] [PATCH] Merging BSD backend into one file.


From: Debarshi Ray
Subject: Re: [Netutils-dev] [PATCH] Merging BSD backend into one file.
Date: Tue, 7 Oct 2008 02:40:47 +0530

> 0003-2008-10-05-Ashish-Shukla-wahjava-gmail.com.diff
>
> @@ -236,8 +239,8 @@ bsd_parse_msg (const sa_family_t sa_family,
>                * NOTE: the length will be dynamic as this is a netmask 
> represented in a sockaddr.
>                */
>               s_len -= (sa_family == AF_INET) ?
> -               (socklen_t)((char*)(&((struct 
> sockaddr_in*)sock_addr)->sin_addr) - (char*)sock_addr):
> -               (socklen_t)((char*)(&((struct 
> sockaddr_in6*)sock_addr)->sin6_addr) - (char*)sock_addr);
> +               (socklen_t)((char*)s_addr - (char*)sock_addr):
> +               (socklen_t)((char*)s_addr - (char*)sock_addr);
>             }
>
>           bsd_conv_addr_to_name ((struct sockaddr *) buffer,

Is the ternary operator needed? s_len is being decremented by
`(socklen_t) ((char *) s_addr - (char *) sock_addr)' in both cases.

Happy hacking,
Debarshi




reply via email to

[Prev in Thread] Current Thread [Next in Thread]