[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pi
From: |
Ralph Corderoy |
Subject: |
Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe |
Date: |
Fri, 15 Feb 2019 23:46:47 +0000 |
Hi az,
> > I'd be tempted to make it an if-then with no else clause by hoisting
> > the "BCC:" prefix and "\n" suffix outside of the if-then.
>
> hmm. i see your point, but don't entirely agree. my aim here was to
> contain all the related logic within the smallest possible/sensible
> horizon.
>
> apart from the small ugliness of having the string "bcc:" hardcoded
> twice i prefer that 'if' block doing its thing (and all of its thing!)
> over strings conditionally accumulating across a pageful of code or
> more.
I don't quite get the comparison so think I may not have got my idea
over. I don't know the context of the patch's chunk so considered it in
isolation. The original,
for (lp = localaddrs.m_next; lp; lp = lp->m_next)
if (lp->m_bcc)
allbcc = allbcc? add(concat(", ", lp->m_mbox, NULL), allbcc)
: mh_xstrdup(lp->m_mbox);
for (lp = netaddrs.m_next; lp; lp = lp->m_next)
if (lp->m_bcc)
allbcc = allbcc? add(
concat(", ", lp->m_mbox, "@", lp->m_host, NULL),
allbcc)
: concat(lp->m_mbox, "@", lp->m_host, NULL);
if (allbcc)
{
fprintf (out, "BCC: %s\n",allbcc);
free(allbcc);
}
seems simpler as
for (lp = localaddrs.m_next; lp; lp = lp->m_next)
if (lp->m_bcc)
allbcc = add(concat(", ", lp->m_mbox, NULL), allbcc);
for (lp = netaddrs.m_next; lp; lp = lp->m_next)
if (lp->m_bcc)
allbcc = add(concat(", ", lp->m_mbox, "@", lp->m_host, NULL),
allbcc);
if (allbcc) {
fprintf(out, "BCC: %s\n", allbcc + 1);
free(allbcc);
}
though I haven't run it, let alone tested it, so it could be simpler but
wrong. :-)
> anyway, these are my personal preferences; i hope we can agree to
> disagree and that somebody with commit rights will apply the patch or
> equivalent to the code.
Yep, absolutely. I see it's already getting attention from David and
I expect Ken will look too.
--
Cheers, Ralph.
- Re: [nmh-workers] Gmail Bounces. (Was: nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe), (continued)
- Re: [nmh-workers] Gmail Bounces. (Was: nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe), Ralph Corderoy, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Ralph Corderoy, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, valdis . kletnieks, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Paul Fox, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Paul Vixie, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, bergman, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Ralph Corderoy, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Ralph Corderoy, 2019/02/15
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Alexander Zangerl, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, David Levine, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe,
Ralph Corderoy <=
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Ken Hornstein, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, valdis . kletnieks, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Ken Hornstein, 2019/02/14
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, valdis . kletnieks, 2019/02/15
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, valdis . kletnieks, 2019/02/15
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Paul Fox, 2019/02/15
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, valdis . kletnieks, 2019/02/15
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Robert Elz, 2019/02/15
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, valdis . kletnieks, 2019/02/15
- Re: [nmh-workers] nmh 1.7.1: both bcc and dcc broken for mts sendmail/pipe, Paul Fox, 2019/02/15