Re: [OATH-Toolkit-help] make check fails with valgrind installed

[Simon Josefsson]

Christian Hesse <address@hidden> writes:

> Simon Josefsson <address@hidden> on Tue, 2013/01/08 21:31:
>> Christian Hesse <address@hidden> writes:
>> 
>> > Hello everybody,
>> >
>> > if valgrind is installed on the system 'make check' fails. The log is
>> > below. This is a memory leak in xmlsec, no?
>> 
>> Hi.  Yes, and the file HACKING contains some hints about this, and we
>> ship a valgrind suppressions file.  Use ./configure
>> --disable-valgrind-tests to disable valgrind.
>
> Ok, will test that.
>
>> However, valgrind should not be used unless requested, so that is a bug.
>> Does that always happen for you?  I've found that always using valgrind
>> when it is available causes too much problems: it is common for system
>> libraries have memory leaks, even libc.  So my opinion is that it should
>> only be on for people who requested it (or build from git).
>
> Yes, it is enabled with release tarball (tested with 2.0.1) as soon as
> valgrind is installed.

Ouch.  I'll see if I can fix this.

/Simon