[Octave-bug-tracker] [bug #29438] regexp: Crash with named subexpressions and nested parentheses

[David Bateman]

Update of bug #29438 (project octave):

                  Status:               Confirmed => Fixed                  
             Assigned to:                    None => dbateman               

    _______________________________________________________

Follow-up Comment #2:

Its not a matter of failing to initialize a variable, but rather as the
original poster pointed out using the grouping operator in the pattern for a
named token cases an issue. The reason is that pcre_exec returns a value with
the number of matches it finds, but this return value is abused to pass
zero-length matches for the parentheses. These zero length matches weren't
correctly ignored for named tokens resulting in octave looking for the second
named token in an internal array when only one was defined and thus a
segfault.

Prove is that although

s = regexp('qwe int asd', ['(?<typestr>(int))'], 'names'); 

segfaults

s = regexp('qwe int asd', ['(?<typestr>int)'], 'names'); 

doesn't. Trivial changeset attached that I have pushed


(file #20177)
    _______________________________________________________

Additional Item Attachment:

File name: patch.regexp                   Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?29438>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/