octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #34953] Bug with qrdelete


From: John W. Eaton
Subject: [Octave-bug-tracker] [bug #34953] Bug with qrdelete
Date: Thu, 01 Dec 2011 09:58:56 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20100101 Firefox/8.0 Iceweasel/8.0

Follow-up Comment #1, bug #34953 (project octave):

This looks like a bug with the qrupdate package, not Octave itself.  Looking
at the source for dqrder here:

http://qrupdate.svn.sourceforge.net/viewvc/qrupdate/src/dqrder.f?revision=1&view=markup

I see


      subroutine dqrder(m,n,Q,ldq,R,ldr,j,w)
...
c arguments:
c m (in)        number of rows of the matrix Q.
c n (in)        number of columns of the matrix R.
c Q (io)        on entry, the orthogonal matrix Q.
c               on exit, the updated matrix Q1.
c ldq (in)      leading dimension of Q. ldq >= m.
c R (io)        on entry, the original matrix R.
c               on exit, the updated matrix R1.
c ldr (in)      leading dimension of R. ldr >= m.
c j (in)        the position of the deleted row.
c w (out)       a workspace vector of size 2*m.
c
...
      if (m < 1) then
        info = 1
      else if (j < 1 .or. j > n) then
        info = 7
      end if
      if (info /= 0) then
        call xerbla('DQRDER',info)
        return
      end if
...


I think that test should be j > m, not j > n.

I fixed the docstring in the following changeset:

hg.savannah.gnu.org/hgweb/octave/rev/62c8205b3fab

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?34953>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]