[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #37099] eval() with '; ' as second parameter c
John W. Eaton
[Octave-bug-tracker] [bug #37099] eval() with '; ' as second parameter causes parse error
Thu, 23 Aug 2012 14:03:37 +0000
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6) Gecko/20100101 Firefox/10.0.6 Iceweasel/10.0.6
Follow-up Comment #3, bug #37099 (project octave):
Thanks for submitting a patch. I'm not applying it because there are some
problems with the change you are proposing.
First, I don't think it makes sense to allow ';' to literally be an
expression. A semicolon is a separator between expressions, not an expression
itself. With the change you made, things like ;++ are accepted as valid
syntax but cause an immediate segfault. Even if you avoid the crash, that
syntax doesn't make sense to me.
Further, with your patch applied, make doesn't complete properly for me. It
fails when trying to build figures for the documentation. If I skip that part
of the build and run "make check" in the test subdirectory, there are some new
test failures. You should get in the habit of running "make check" after
making any change so that you can be sure you haven't introduced any
Also, a few minor points about submitting changes:
* Please don't use tabs for indenting in Octave source files.
* Please follow the conventions of commit messages as outlined here:
If you'd like to see examples of commit messages, look at a sampling of the
commit messages for changes that I have made.
Reply to this item at:
Message sent via/by Savannah