[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #37297] Meaningless test in fftfilt.m, patch t

From: Dan Sebald
Subject: [Octave-bug-tracker] [bug #37297] Meaningless test in fftfilt.m, patch to address this issue as well enhance final touchup of routine and fix rounding bug
Date: Fri, 19 Oct 2012 04:03:26 +0000
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20111108 Fedora/3.6.24-1.fc14 Firefox/3.6.24

Follow-up Comment #4, bug #37297 (project octave):

This patch is an update of octave-fftfilt-2012sep11.patch, having only a minor
change of fix for computing the index for columns to be rounded.  The index
should be an integer array, not logical array.  Note that this patch was
generated using "hg export" and has the prescribed documentation header.

I didn't include eem2314's patch, so that will have to be re-added.  Let's try
this a bit differently than using patch/modify/diff, and see if we can create
a series of commits in a file as though it were done using push/pull.  That

1) use "hg import" to apply the latest patch
2) make the modifications for the new tolerance settings
3) commit those changes with the proper header documentation
4) "hg export" one previous to the tip (look at the "hg log")
5) attach the exported diff file here

This way, we'll have a series of diffs in just one file, easily applied by
maintainers and giving credit of mods where appropriate.  Rather than redoing
the patch for any tweaks, we'll just add more change sets.  We'll see how that

As for the problems that someone on the help-octave list is seeing for a
compilation that might have a different math library, I just don't see how
that can affect the rounding behavior and cause a test failure.  The result
should be exact integer values for the first set of tests, and there isn't
much that affects this:

  if (! any (b - fix (b)))
    idx = find (! any (x - fix (x)));
    y (:, idx) = round (y (:, idx));

That's it.  Could it be that the fix() routine fails under some other library
so that one of the conditional tests fails?  I don't know.  I think the person
who is seeing the problem will have to simply cut and past the test script and
walk through the test looking at intermediate results.

(file #26788)

Additional Item Attachment:

File name: octave-fftfilt-2012oct18.patch Size:5 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]