[Octave-bug-tracker] [bug #38075] 'make' fails with "Argument list too long" message

[Rik]

Update of bug #38075 (project octave):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #4:

'sed -f pattern_file' won't work because the patterns are not static at
configure time, but can be changed at compile time by running 'make myvar=XXX
all'.  Make is the only one who knows about these changes.

The current approach works because it relies on the shell to do variable
expansion.  We place the patterns on the command line with 'sed -e
"s|pattern|${variable}|' and the shell does a round of variable expansion to
make 'sed -e "s|pattern|replacement|"'.

Once I figured that we couldn't use 'sed -f' I just threw it into Perl and I
think the code looks easy to maintain.  Each pattern and replacement is on
it's own line and it's quite straightforward to copy/paste to add a new
variable as they come along.

Performance is an issue for this piece of code because it is called 3 times
for every invocation of "make all".  Even if there is nothing to rebuild, Make
has to run this piece of code to verify that it wasn't called with different
options which would trigger a compile.

I'll go ahead and commit it.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?38075>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/