[Octave-bug-tracker] [bug #36408] inverted axes with long right justified legends

[Rik]

Follow-up Comment #14, bug #36408 (project octave):

It appears everyone but me is getting to travel, harumph!  OctConf is starting
in Milan on Monday and here you are off in Asia.

Anyways, I think the patch goes a long way towards fixing things.  I'm
attaching a png that I made using the bug_34608.m script that I had attached
earlier to this report.  As you can see, there is still a bit of fine tuning
needed.  The actual text of the legend is now being positioned correctly, but
the positioning is not taking into account the box surrounding the legend so
there are a few pixels worth of overlap that still need addressing.

>From a coding style, it appears that the rest of the scripts in the plot
directory are using


%!clf;
rather than
%!clf ();


For consistency I would keep up that convention.

Also, when using long line continuations, jwe prefers that the line start with
a "verb" rather than a "noun".  I would re-write some sequences as shown
below.


extra_offset = unmodified_axes_outerposition(1) + ...
  unmodified_axes_outerposition(3) - ...
  unmodified_axes_position(1) - ...
  unmodified_axes_position(3);

rewrite to

extra_offset = unmodified_axes_outerposition(1) ...
             + unmodified_axes_outerposition(3) ...
             - unmodified_axes_position(1) ...
             - unmodified_axes_position(3);


When making function calls, unless the line is extremely long, it is also
standard practice to not use just a 2-space indent but to align to the
parenthesis which starts the function call.  I would rewrite


addproperty ("unmodified_axes_position", hlegend, "data", ...
  unmodified_axes_position);

rewrite to

addproperty ("unmodified_axes_position", hlegend, "data", ...
             unmodified_axes_position);

or even to

addproperty ("unmodified_axes_position", hlegend, ...
             "data", unmodified_axes_position);

since this clearly exposes the property/value pair being added.


Hope this helps.  Post again if you want me to review further.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36408>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/