[Octave-bug-tracker] [bug #39723] history commands lost when selecting block and right-clicking "Evaluate"

[Dan Sebald]

URL:
  <http://savannah.gnu.org/bugs/?39723>

                 Summary: history commands lost when selecting block and
right-clicking "Evaluate"
                 Project: GNU Octave
            Submitted by: sebald
            Submitted on: Thu 08 Aug 2013 01:38:18 AM GMT
                Category: GUI
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: GNU/Linux

    _______________________________________________________

Details:

After the changeset in bug report #39722, selecting a block of commands in the
history window and then evaluating via the right click mechanism will not
process all commands.  Some appear to be lost in the signal/slot communication
with the core.

For example, I issue "test assert" several times at the command line, select a
block of four of them and when right-clicking "Evaluate" get:


>>
>> test assert
PASSES 57 out of 57 tests
>> test assert


i.e., two were dropped.  Also, it appears to be random in the sense that
sometimes there are three commands processed.  I have confirmed in this hunk
of code from history-doc-widget.cc:


void history_dock_widget::handle_contextmenu_evaluate(bool)
{
  QItemSelectionModel *selectionModel = _history_list_view->selectionModel();
  QModelIndexList rows = selectionModel->selectedRows();
  QModelIndexList::iterator it;
  for (it = rows.begin() ; it != rows.end(); it++)
    {
      if ((*it).isValid())
        emit command_double_clicked ((*it).data().toString());
    }
}


that in fact all commands are being emitted in the for-loop.  So it seems to
me that the slot on the receiving end of the signal is dropping commands if
they come too quickly, not sure.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39723>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/