[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #32120] complex times complex failure

From: Michael C. Grant
Subject: [Octave-bug-tracker] [bug #32120] complex times complex failure
Date: Mon, 17 Mar 2014 01:19:42 +0000
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.74.9 (KHTML, like Gecko) Version/7.0.2 Safari/537.74.9

Follow-up Comment #17, bug #32120 (project octave):

OK, here's a patch that seems to do the trick.

Here's what it does: in ax_blas.m4, it creates a new define USE_CBLAS_COMPLEX
that is set to 1 when the "-framework vecBlas" version of the BLAS is
detected. This define is then used in CMatrix.cc and fCMatrix.cc to replace
the calls to xzdotu, etc. to corresponding CBLAS calls.

I've tested this and found it does indeed produce the correct results for both
single and double precision.

It seems to me that it might be a good idea to generalize this: instead of
defining USE_CBLAS_COMPLEX for the specific case of vecLib, you could test for
the existence of these functions in whatever BLAS library was successfully
called, and then define USE_CBLAS_COMPLEX whenever they are found.

By the way, USE_BLASWRAP and the corresponding code in blaswrap.c should
probably be dropped. It seems to me this is much less fragile solution.

(file #30922)

Additional Item Attachment:

File name: cblas.diff                     Size:4 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]