[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #41827] Fix dead assignment octave_rand::do_fl

From: Rik
Subject: [Octave-bug-tracker] [bug #41827] Fix dead assignment octave_rand::do_float_scalar
Date: Thu, 20 Mar 2014 16:01:30 +0000
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0

Update of bug #41827 (project octave):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 


Follow-up Comment #3:

The first patch is always the hardest trying to understand all of our coding
conventions and styles.  I made a few tweaks to your patch.

1) I added an initial line that summarizes the changeset and mentions the bug

"Fix dead assignment in oct-rand.cc do_float_scalar (bug #41827)."

2) In the test section, I added a line '%!test' just ahead of your new code so
that your test will be counted by itself, rather than being a part of the
previous %!test block.

3) I also added you to the list of contributors to Octave which is in the
preface of the manual.  We like to acknowledge everyone who helps out.

The changeset is here


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]