[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #44370] Octave compiler flags used at build ti

From: Mike Miller
Subject: [Octave-bug-tracker] [bug #44370] Octave compiler flags used at build time are not used by mkoctfile
Date: Thu, 26 Feb 2015 03:33:45 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.111 Safari/537.36

Follow-up Comment #10, bug #44370 (project octave):

This is awesome, thanks for coming up with that so quickly. It almost works
for me. I've made a few more changes in the attached diff, feel free to merge
it into yours. I think these go with the pattern you are going with.

So this looks really good, HAVE_HDF5 doesn't show up in any public header
files now, except for the ones that explicitly have to do with hdf5, and the
load_hdf5 and save_hdf5 functions are no longer conditional.

I've already updated the communications package to use this new interface and
it at least builds, not yet tested. But this looks like the right direction to

Should we move this to bug #43180 since it directly fixes that one also?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]