[Octave-bug-tracker] [bug #44653] bolling.m in financial pkg does not use width parameter, gives incorrect result

[Carnë Draug]

Follow-up Comment #4, bug #44653 (project octave):

Your cset http://hg.code.sf.net/u/azimzadeh/octave/rev/f44ed8cda0cd does more
than just the fixing the bug. Could you split it into two separate commits.

Can you please address the following:

1. Follow octave coding guidelines. We follow the [GNU
format](http://www.gnu.org/prep/standards/standards.html#Formatting). The main
thing is leave a space between a function name and the opening brackets and
continue the contents of brackets with that indentation. So this

    plot( ...
      x, asset(:),    '-b', ...
      x, avg(:),      '-k', ...
      x, avg(:)+s(:), '-r', ...
      x, avg(:)-s(:), '-r'  ...
    );

would become

    plot (x, asset(:), "-b", x, avg(:), "-k",
          x, avg(:) .+ [-s(:) +s(:)], "-r")

Note the space in `plot (`, change to double quotess, and no need for `...`. I
am also unsure that there's need to be constantly `(:)`

Also, are you also submitting the other cset, which adds a new function
amerbinary, for review?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44653>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/