[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replac
From: |
Pantxo Diribarne |
Subject: |
[Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package |
Date: |
Thu, 12 Nov 2015 21:43:46 +0000 |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 |
Follow-up Comment #21, bug #45951 (project octave):
@Philip:
>> The numeric argument isn't undocumented, see e.g., "help xmlread". It could
be more clear, though.
Sorry I hadn't carefully read the help string :-)
>> Indeed, I could change behavior into persistently checking ... Would that
be better? That'd be an easy fix - see attached.
Sure that is exactly what I meant. A user shouldn't have to use debug
arguments to force a function to check the path again.
>> Why check for "nargout > 0" in xmlwrite.m when returning the xml string?
You are right, checking the output stream is a StringWriter is enough.
Now about returning an int on success when writing to file, I'd say it is
useless as the function will error out otherwise. I'd leave the warning but
that is no big deal.
I notice that you have moved base Java support checks a little below the first
java calls in xmlwrite :-). Could you move them at the top again? Or I can do
it if you want.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?45951>
_______________________________________________
Message posté via/par Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package, Philip Nienhuis, 2015/11/09
- [Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package, Pantxo Diribarne, 2015/11/10
- [Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package, Pantxo Diribarne, 2015/11/11
- [Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package, Philip Nienhuis, 2015/11/11
- [Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package,
Pantxo Diribarne <=
- [Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package, Philip Nienhuis, 2015/11/12
- [Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package, Philip Nienhuis, 2015/11/18
- [Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package, Pantxo Diribarne, 2015/11/18
- [Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package, Philip Nienhuis, 2015/11/19
- [Octave-bug-tracker] [bug #45951] Add "xmlread" to core Octave or replace the one in io package, Pantxo Diribarne, 2015/11/20