[Octave-bug-tracker] [bug #31946] pkg: better error reporting when trying to remove system packages

[Mike Miller]

Follow-up Comment #7, bug #31946 (project octave):

This is an improvement in the right direction. I now see


>> pkg uninstall control
warning: control is a system installed package and cannot be removed by a
user
warning: no packages will be uninstalled
warning: called from
    uninstall at line 88 column 5
    pkg at line 420 column 7



If I try to uninstall two packages at once, one system-installed and one
user-installed, I see


>> pkg uninstall control optim
warning: control is a system installed package and cannot be removed by a
user


and the optim package is uninstalled. I guess this is similar to the current
case of uninstalling one installed package and one wrong package name.

The coding style is mostly right, except for a missing space in "length(", and
you inadvertently deleted an extra newline at the end of the file. The naming
of the new variables is not at all clear, looking at the code I don't have a
hint as to what the purpose of "delete_idx" versus "delete_idx1" is.

Any other reviewers more familiar with pkg.m?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?31946>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/