[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #48439] validateattributes throws errors witho
From: |
Rik |
Subject: |
[Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs |
Date: |
Tue, 12 Jul 2016 16:01:58 +0000 (UTC) |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 |
Follow-up Comment #6, bug #48439 (project octave):
Rik here, I actually disclaim responsibility for the 4.2.0 release. I'm very
busy at work and then off for two weeks so I will help where I can, but can't
manage the whole process this time.
As for the patch, it seems appropriate.
A couple questions, first
error ("Octave:invalid-invalid-type"
Should the word "invalid" really be repeated? Maybe this would be better?
error ("Octave:invalid-type"
In the BIST tests, jwe prefers the use of double quotes to single quotes.
Could you do a search and replace from ' to ". Also, Octave coding
conventions are for a space between the function name and the opening
parenthesis: "ones(1,2,3)" => "ones (1,2,3)". It is slightly longer, but I
think more readable, if you can use newlines and indentation to show the
different sections of a try/catch block. Summing up, I would change the first
BIST test
%!test
%! try validateattributes (ones(1,2,3), {'numeric'}, {'2d'});
%! catch id,
%! assert (getfield (id, 'identifier'), 'Octave:expected-2d');
%! end_try_catch
to read as follows:
%!test
%! try
%! validateattributes (ones (1,2,3), {"numeric"}, {"2d"});
%! catch id
%! assert (getfield (id, "identifier"), "Octave:expected-2d");
%! end_try_catch
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?48439>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/07
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/07
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Lachlan Andrew, 2016/07/08
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/11
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs,
Rik <=
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carnë Draug, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Rik, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carnë Draug, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Rik, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/12
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carnë Draug, 2016/07/13
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carnë Draug, 2016/07/22
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carlo de Falco, 2016/07/24
- [Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs, Carnë Draug, 2016/07/24