[Octave-bug-tracker] [bug #48013] Java integration: conversion to double

[Mike Miller]

Follow-up Comment #11, bug #48013 (project octave):

Thank you. I have made some more formatting fixes and small simplifications.
Please find attached a patch that combines your two patches and my changes.

This change still needs unit tests to verify the cases when numeric conversion
is done and not done. As it is right now the code looks fine but I have no
examples to run against to verify whether it is working as expected. Can you
help write those?

For your future reference, the changes I made are:

* Removed trailing spaces on almost every line changed. Your editor leaves
trailing white space on each line, please try to fix the editor or search and
delete all trailing white space before finalizing patches.

* The test for whether jobj is a java.lang.Number is redundant now with the
new helper function, so I deleted it.

* I reworded and reformatted the doxygen docs you added for the new function
and for the box function.

* Your surname is spelled "Reissnere" in your submitted patches, but
"Reissner" is correct, right? Please fix your ~/.hgrc for future submissions
if that is right.

(file #38043)
    _______________________________________________________

Additional Item Attachment:

File name: bug-48013-mtm.patch            Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48013>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/