[Octave-bug-tracker] [bug #49990] signal package: butter/ellip/cheby1/cheby2 error if only asking for a single output

[Mike Miller]

Update of bug #49990 (project octave):

                  Status:               Confirmed => Patch Submitted        

    _______________________________________________________

Follow-up Comment #7:

Thanks. I would clean this up a bit, feel free to update your patch if you
want to help me out, otherwise I can take care of it.

* use "(bug #nnn, bug #nnn)" in the summary line to make hg history more
searchable
* no need for the explanatory comments about orientation or "fix bug#nnn" in
the code, those should be explained by looking at the hg history
* simplify to just have a case for "if (nargout <= 2)", it won't cause an
error to assign to both a and b even if nargout is only 1 (maybe efficiency,
but that doesn't seem to be a concern here)
* don't add a space when indexing with "(:)", we only add space before
function call arguments, not indexing operations
* in the commit message, if the change is the same for all four files, just
say "* butter.m, cheby1.m, cheby2.m, ellip.m: ..."
* blank line between the summary line and the bullet lines in the commit
message

Thanks

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?49990>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/