[Octave-bug-tracker] [bug #50105] __ilu__ and __ichol__ should use liboctave functions instead of feval

[John W. Eaton]

URL:
  <http://savannah.gnu.org/bugs/?50105>

                 Summary: __ilu__ and __ichol__ should use liboctave functions
instead of feval
                 Project: GNU Octave
            Submitted by: jwe
            Submitted on: Fri 20 Jan 2017 07:05:46 PM GMT
                Category: Octave Function
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Performance
                  Status: None
             Assigned to: None
         Originator Name: jwe
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: BSD

    _______________________________________________________

Details:

In __ilu__.cc and __ichol__.cc, there are many calls to feval to execute the
functions tril, triu, speye, and norm that should use liboctave functions
directly.

Using feval for this is inefficient since it may involve the interpreter and
always involves unnecessary conversion to/from octave_value objects.

For norm, we already have functions in liboctave to do the job.

For speye, I think it should be possible to call the sparse matrix contructor
to generate a sparse identity matrix.  If not, then we could easily define an
speye function in liboctave.

For tril and triu, we should probably move the templates from corefcn/tril.cc
to liboctave and export them in a public header file.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50105>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/