[Octave-bug-tracker] [bug #48793] no need for OCTAVE_LOCAL_BUFFER anymore

[Rik]

Follow-up Comment #5, bug #48793 (project octave):

We came across the same problem in regexp.cc.  I fixed it on the stable branch
since it isn't right to have potentially segfaulting code there.  I also
switched to OCTAVE_LOCAL_BUFFER_INIT so I could get rid of the for loop.  See
http://hg.savannah.gnu.org/hgweb/octave/rev/fdce2b73f5ce.

For the other questions, there weren't advantages to the old system because
they were never being used (#if 0 was disabling them completely at
compile-time).  I was going to do performance benchmarking to see if anything
has changed.  I suspect the current implementation may be a bit slower because
the default constructor for object T is called N times.  The second
implementation that I wrote, which uses char as the default data type to
allocate bytes may be preferable.  In that case, there will still be
initialization, but for a POD data type that should just be filling with 0. 
There would be no calling of potentially long constructor chains.  Ideally,
there is a way to just allocate storage without initialization, but that
sounds like using malloc rather than new.  Maybe that is worth a question on
Stack Overflow?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48793>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/