[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #48793] no need for OCTAVE_LOCAL_BUFFER anymor

From: Rik
Subject: [Octave-bug-tracker] [bug #48793] no need for OCTAVE_LOCAL_BUFFER anymore
Date: Wed, 19 Jul 2017 16:31:06 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0

Follow-up Comment #7, bug #48793 (project octave):

I'm still building for testing, but I think that using char to represent bytes
is going to be the best solution.

According to this, http://en.cppreference.com/w/cpp/language/initialization,
new without arguments will call default initialization.  For class objects,
this would mean the default constructor.  For POD types, there is no default
constructor so the value is unitialized (just what we want here).

Testing results for 'time make check'

# Original code
410.172u 28.320s 7:32.17 96.9%  0+0k 152+85440io 0pf+0w
410.452u 27.700s 7:31.92 96.9%  0+0k 32+85520io 0pf+0w

# T style
415.240u 29.312s 7:40.00 96.6%  0+0k 211312+85544io 802pf+0w
416.556u 28.180s 7:39.69 96.7%  0+0k 152+85392io 0pf+0w

So, there is a small (1.2%) but repeatable slowdown.  I'm going to try using
the char technique and see if that makes a difference, but I'm getting another
segfault at the moment.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]