[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #51738] [octave-forge] (image) bug in montage
From: |
Carnë Draug |
Subject: |
[Octave-bug-tracker] [bug #51738] [octave-forge] (image) bug in montage function |
Date: |
Sat, 12 Aug 2017 20:29:25 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 |
Follow-up Comment #2, bug #51738 (project octave):
> and it looks to me like it should be
>
> [images(:,:,:,page_range), map] = imread (img_info.Filename, 1:nPages);
>
> as img_info is the current image according to the earlier line
Needs to be 'img_info(1).Filename' because while img_info is already the
imfinfo for the current image, if the current image is a multipage file, then
it will be a struct array.
I have fixed this now with
http://hg.code.sf.net/p/octave/image/rev/c38a1f64dafb
> The earlier check on line 144
>
> if (size (images, 3) == 1 || all (strcmp {img_info(:).ColorType},
"truecolor")))
>
> also looks suspect to me as again img_info is the current image info and not
the collection of image infos.
A multipage file may have a combination of colortypes, between binary,
grayscale, and RGB (truecolor). That 'img_info(:)' checks that they are all
RGB.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?51738>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/