octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #52310] [octave-forge] io: read_namelist canno


From: Philip Nienhuis
Subject: [Octave-bug-tracker] [bug #52310] [octave-forge] io: read_namelist cannot read character sequences containing a /
Date: Mon, 30 Oct 2017 14:25:38 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48

Follow-up Comment #1, bug #52310 (project octave):

(io pkg maintainer here)
Thanks for the bug report and patch, Brice

Against which io package release have you made the patch?  because recently
io-2.4.8 was released and one or two days earlier another patch for
read_namelist.m had been applied. That one and your patch shouldn't "cross"
:-)

As to your patch: some small style thingies:
* space between function name and left parenthesis (L. 17, 26, 41, 52, 53, 59,
63, ...)
* no ";" after an if clause (L. 15)
* we use ## at start of comment rather than %
* space between ! and logical expression (L. 42, ...)

I have little experience with Fortran since ~2000 so I  more or less have (to
have) blind faith in namelist patches :-)
Maybe someone else can comment on this patch' merits.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52310>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]