[Octave-bug-tracker] [bug #52800] The icon for dock widgets for *figure* windows needs improvement

[Dan Sebald]

URL:
  <http://savannah.gnu.org/bugs/?52800>

                 Summary: The icon for dock widgets for *figure* windows needs
improvement
                 Project: GNU Octave
            Submitted by: sebald
            Submitted on: Wed 03 Jan 2018 09:09:38 PM UTC
                Category: GUI
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Regression
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: GNU/Linux

    _______________________________________________________

Details:

I've noticed that the logo used in the system dock works properly except the
fact that plot figure windows have a real inconsistent behavior.  Since it is
most often a bunch of figure windows that accumulate along the dock in typical
use, it would be nice to somehow assign a proper PNG to those, if possible.

In gnuplot graphics toolkit, it is the standard gnuplot figure of a little
plot with basic color lines on it.  In FLTK toolkit, it looks to be the
default system icon which in this case is a black background with red
"cross-out", or Ghost Busters :-), logo.  In Qt toolkit, it is the standard
Octave logo (what would be "NONE" in GUI settings parlance).

In some sense it is the last case, Qt graphics toolkit, that is the most
problematic because it mimics the main GUI icon.  I like having the main icon
unique so that I can quickly find it.

What would be the best icon for a figure?  Perhaps just the standard Octave
icon with the number of the window superimposed on it.  Otherwise, the logo
with a small plot.

BTW, I notice this hunk of code:


  // which icon has to be selected
  QButtonGroup *icon_group = new QButtonGroup (this);
  icon_group->addButton (ui->general_icon_octave);
  icon_group->addButton (ui->general_icon_graphic);
  icon_group->addButton (ui->general_icon_letter);
  QString widget_icon_set =
    settings->value ("DockWidgets/widget_icon_set", "NONE").toString ();
  ui->general_icon_octave->setChecked (true);  // the default (if invalid
set)
  ui->general_icon_octave->setChecked (widget_icon_set == "NONE");
  ui->general_icon_graphic->setChecked (widget_icon_set == "GRAPHIC");
  ui->general_icon_letter->setChecked (widget_icon_set == "LETTER");


doesn't set "NONE" as default as the comment says.  At least, the logic
doesn't seem to do that.  It sets general_icon_octave to "true" initially, but
then immediately after that sets general_icon_octave again.  Let's say
widget_icon_set is "HUH?!".  Then all three of the above will be false at the
end of this hunk.  In other words, right now that line that has "// the
default (if invalid set)" effectively does nothing.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52800>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/