[Octave-bug-tracker] [bug #49053] figure scaling issue with Qt 5 on macOS with Retina / HiDPI scaling

[Mike Miller]

Follow-up Comment #48, bug #49053 (project octave):

Please incorporate the attached patch into yours, you'll have to run
./bootstrap or autoreconf after applying the patch.

Please use "#if defined (HAVE_QSCREEN_DEVICEPIXELRATIO)" instead of HAVE_QT5.
Also please ensure the #if is always in column 1, not indented with the rest
of the code, and the code within the #if block should be indented the same as
if the #if weren't there.

The latest patch looks a lot better, thank you.

My few remaining nitpicks:
* your editor is inserting tab characters, please always use spaces to indent,
and make sure there are no extra spaces at the end of a line or on a blank
line
* "QApplication::screens().at(0)" should be "QApplication::screens ().at (0)",
and "devicePixelRatio()" should be "devicePixelRatio ()"

Have you tried using QApplication::primaryScreen ()? Seems simpler and should
be the same as QApplication::screens ().at (0), maybe, hopefully?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?49053>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/