[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #53019] [octave forge] (signal) zplane plottin
From: |
Mike Miller |
Subject: |
[Octave-bug-tracker] [bug #53019] [octave forge] (signal) zplane plotting enhancements |
Date: |
Tue, 20 Mar 2018 18:56:53 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 |
Follow-up Comment #3, bug #53019 (project octave):
This is going to take some time to review since it is not in a minimal patch
format.
If you want to help me review this faster, it would be very helpful to only
make the minimal changes to the function. As it is it's hard for me to tell
which changes are functionally necessary and which aren't. I'm sorry if my
comment #1 led you to make more changes than were necessary, I was talking
about the lines that you already changed or added.
If you don't want to work on this anymore, I will try to pull out the changes
from the second revision that are functionally necessary to fix this bug. I
think that is everything after the "a = axis" line.
Am I right in presuming that the purpose of the "axis" addition is to allow
the zplane to be plotted into an already present axes object? Is that Matlab
compatible? I would rather not include that change if that's not the way
Matlab works.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?53019>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/