[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #53561] pkg install reports an error when file

From: Mike Miller
Subject: [Octave-bug-tracker] [bug #53561] pkg install reports an error when filename doesn't match package name
Date: Wed, 4 Apr 2018 17:58:25 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

Update of bug #53561 (project octave):

                  Status:                    None => Patch Submitted        


Follow-up Comment #1:

This is trivial to solve, by just removing the block of code that performs
this test. Nothing else is affected by removing this block of code:

--- a/scripts/pkg/private/install.m
+++ b/scripts/pkg/private/install.m
@@ -112,14 +112,6 @@ function install (files, handle_deps, pr
         filename = fullfile (packdir, "DESCRIPTION");
         desc = get_description (filename);
-        ## Verify that package name corresponds with filename.
-        [dummy, nm] = fileparts (tgz);
-        if ((length (nm) >= length (desc.name))
-            && ! strcmp (desc.name, nm(1:length (desc.name))))
-          error ("package name '%s' doesn't correspond to its filename
-                 desc.name, nm);
-        endif
         ## Set default installation directory.
         desc.dir = fullfile (prefix, [desc.name "-" desc.version]);

So this condition was added as an intentional nitpick on the naming of the
package tar file, which seems pointless to me, but I'll give this a day or two
to see if anyone can tell me that this is important to keep.

The whole point of me pursuing this is to allow users to install a package
straight from a remote git or mercurial repo, where the file may be named
something like 'tip.tar.gz' or 'master.zip'.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]