[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #53489] linspace and logspace with endpoints (

From: Mike Miller
Subject: [Octave-bug-tracker] [bug #53489] linspace and logspace with endpoints (Inf, Inf) is different than Matlab
Date: Wed, 4 Apr 2018 21:16:41 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

Update of bug #53489 (project octave):

                  Status:               Confirmed => Patch Submitted        


Follow-up Comment #4:

Maor - you don't need to open a patch tracker item to submit a patch for a
bug, attaching it here is good enough as you have done. Even better would be
to post a comment saying that you have attached a fix, because otherwise its
existence is hidden way at the bottom of the page here.

The change you have written looks functionally correct and was exactly along
the lines of what I was thinking as a fix for this, good job. This looks like
a clean fix and addresses all of the typed linspace functions.

The test cases look right to me, do you happen to have access to Matlab to see
whether these all behave the same? Do you care to add a few more test cases,
like maybe [0,∞], [-∞,0], reverse ranges like [∞,-∞]? Should there be
test cases added to logspace.m as well?

The rest of this feedback is about the style rather than the content of your

Please make sure your coding style matches the Octave style guide
(https://wiki.octave.org/Octave_style_guide), the test cases you have added so
far don't.

Can you change your hg username to be your full name with proper

The commit message should be written to follow the commit message guidelines
(https://wiki.octave.org/Commit_message_guidelines). The format of your commit
message looks correct, but not the message itself. The summary line should
describe the change, not just "fix bug #foo". Something like "linspace: handle
ranges with equal Inf endpoints (bug #53489)".

The commit message body needs to mention every file and function within that
file that was touched. See
https://hg.savannah.gnu.org/hgweb/octave/rev/a3bd04422a87 for a perfect
example of a commit message that changed the same method in the various Matrix


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]