[Octave-bug-tracker] [bug #53995] [patch] Fix text color in highlighted workspace variables when using a dark theme

[Mayeul Cantan]

URL:
  <http://savannah.gnu.org/bugs/?53995>

                 Summary: [patch] Fix text color in highlighted workspace
variables when using a dark theme
                 Project: GNU Octave
            Submitted by: mayeulc
            Submitted on: Sun 27 May 2018 10:42:42 PM UTC
                Category: GUI
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Other
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

When using a dark theme, text color defaults to a very light value (white in
my case). The contrast is then too low to read information against the
highlighted background in the workspace view.

Attached is a patch that sets the foreground color to black when the
background is highlighted.
Of course, ideally we would compute the foreground color dynamically, but it
looks like this is enough for most cases.

Also changes BackgroundColorRole (which is marked as obsolete in the
documentation) to BackgroundRole.

I am not sure this is the right way to submit patches, but that's what was
written on the website.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 27 May 2018 10:42:42 PM UTC  Name: highlight-foreground-color.patch 
Size: 1KiB   By: mayeulc

<http://savannah.gnu.org/bugs/download.php?file_id=44235>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53995>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/