[Octave-bug-tracker] [bug #54182] .o files created by mkoctfile should be removed

[John W. Eaton]

Follow-up Comment #8, bug #54182 (project octave):

No, we should not be using gnulib when CROSS is defined.  When CROSS is
defined, we are building an executable to run on Linux that builds .oct files
that are intended to run on Windows.  And mxe-octave has only configured and
built a copy of gnulib for Windows, not Linux.

I fixed it this way instead:

http://hg.savannah.gnu.org/hgweb/octave/rev/ace13ff63b90

There is no distinction between text and binary files on Linux systems, so
O_BINARY shouldn't be needed in the flags argument of mkostemps anyway.

If at some point we decide that we do need the portability fixes that gnulib
provides when we are building mkoctfile with CROSS defined, then we'll have to
fix the mxe-octave and Octave build systems so that when cross compiling, we
cross-compile gnulib AND we also build a native version that can be used when
building the cross-compiler version of the tools like mkoctfile (i.e., the one
that runs on Linux and creates Windows .oct files).  That seems like a lot of
unnecessary work at this point so I only want to do it if it is really needed.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54182>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/