[Octave-bug-tracker] [bug #48505] build does not use any warning options in libgui/qterminal

[Rik]

Follow-up Comment #11, bug #48505 (project octave):

I did a sanity check on the compilations by comparing the log files of the
make process.


hg update -r 053502516f38  # Before change
make clean
make -j1 V=1 |& tee oldmake.log

hg update                  # After change
make clean
make -j1 V=1 |& tee newmake.log

sort oldmake.log > sort.oldmake.log
sort newmake.log > sort.newmake.log

diff -b oldmake.log newmake.log > diffs.to_inspect


There are a few differences that I would have you look at.  The file is
attached as diffs.to_inspect.

The first difference I see is that we are now including the WARN_FLAGS when
compiling in liboctave.  For example,


210c212
< /bin/bash ./libtool  --tag=CC   --mode=link gcc -fPIC -pthread -fopenmp -O2
-pipe   -o liboctave/external/blas-xtra/libxerbla.la 
liboctave/external/blas-xtra/liboctave_external_blas_xtra_libxerbla_la-xerbla.lo
 -lutil  -lm 
---
> /bin/bash ./libtool  --tag=CC   --mode=link gcc -fPIC -pthread -fopenmp
-Wall -W -Wformat -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes
-Wwrite-strings -Wcast-align -Wcast-qual -O2 -pipe   -o
liboctave/external/blas-xtra/libxerbla.la 
liboctave/external/blas-xtra/liboctave_external_blas_xtra_libxerbla_la-xerbla.lo
 -lutil  -lm 


This is probably okay.  However, it has produced two new warnings during
compilation.


2978a2986,2987
> liboctave/external/blas-xtra/xerbla.c:48:1: warning: no previous prototype
for ‘octave_set_xerbla_handler’ [-Wmissing-prototypes]
> liboctave/external/blas-xtra/xerbla.c:57:1: warning: no previous prototype
for ‘xerbla_’ [-Wmissing-prototypes]


The last area that needs inspection are three files in dldfcn.  Looking just
at __init_gnuplot__.cc I see during the link


< /bin/bash ./libtool  --tag=CXX   --mode=link g++ -std=gnu++11 -fPIC -pthread
-fopenmp -Wall -W -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings
-Wcast-align -Wcast-qual -I/usr/include/freetype2 -I/usr/include/freetype2 -O2
-pipe -avoid-version -module -no-undefined     -o
libinterp/dldfcn/__init_gnuplot__.la -rpath /home/rik/local/lib/octave/5.0.0
libinterp/dldfcn/libinterp_dldfcn___init_gnuplot___la-__init_gnuplot__.lo  
-lutil  -lm 
1272a1272
> /bin/bash ./libtool  --tag=CXX   --mode=link g++ -std=gnu++11 -fPIC -pthread
-fopenmp -Wall -W -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings
-Wcast-align -Wcast-qual -O2 -pipe -avoid-version -module -no-undefined     -o
libinterp/dldfcn/__init_gnuplot__.la -rpath /home/rik/local/lib/octave/5.0.0
libinterp/dldfcn/libinterp_dldfcn___init_gnuplot___la-__init_gnuplot__.lo  
-lutil  -lm 


The old compile was including "-I/usr/include/freetype2" twice.  Twice seems
excessive, but once might be necessary if gnuplot really does depend on
FreeType.


(file #44546)
    _______________________________________________________

Additional Item Attachment:

File name: diffs.to_inspect               Size:21 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48505>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/