octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #54602] (patch) fix behavior of octfile signed


From: Rik
Subject: [Octave-bug-tracker] [bug #54602] (patch) fix behavior of octfile signed int mod
Date: Fri, 7 Sep 2018 12:54:00 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Update of bug #54602 (project octave):

                  Status:          Patch Reviewed => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #4:

I pushed your patch to the stable branch here
(https://hg.savannah.gnu.org/hgweb/octave/rev/1f52a96c8c21).

I added a commit message which follows the GNU style conventions.  I also
added the bug number in the commit message summary which is an Octave
convention so we can determine quickly what the code change was for.  Finally,
I added some built-in self tests (BIST) so that if we accidentally revert this
behavior we will find it quickly when running the test suite.

In a separate changeset
(https://hg.savannah.gnu.org/hgweb/octave/rev/5f22779e6857) I added you to the
list of contributors to Octave.  Welcome aboard!

Marking bug as fixed and closing report.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54602>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]