[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graph
From: |
Pantxo Diribarne |
Subject: |
[Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle |
Date: |
Wed, 3 Oct 2018 04:35:52 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 |
Follow-up Comment #10, bug #42490 (project octave):
@Dan: Thanks for testing. I do think this is the way to go (and the only way
in which we can be Matlab compatible) and I also thing the other dialogs
(questdlg, inputdlg, ...) should be implemented the same way (even though
there is no constraint of returning a figure handle for those). The fact that
dialogs can be resized is another bug: the "resize" figure property of dialogs
is correctly set "off" but this property is currently ignored by all graphics
toolkits.
As I said I had anticipated that this png file inclusion was not correct. I
see "File scripts/gui/__error-icon__.png: git binary diffs are not supported"
when you apply the patch. The --git option is the only way I know of for
including binary data in a patch, and applying the patch on another computer
works for me:
$ hg qimport ~/Downloads/msgbox_fig4.patch
adding msgbox_fig4.patch to series file
$ hg qpush
applying msgbox_fig4.patch
patching file libgui/graphics/BaseControl.cc
patching file libgui/src/octave-qt-link.cc
patching file libgui/src/octave-qt-link.h
patching file libinterp/corefcn/octave-link.cc
patching file libinterp/corefcn/octave-link.h
patching file scripts/gui/__error-icon__.png
patching file scripts/gui/__help-icon__.png
patching file scripts/gui/__warn-icon__.png
patching file scripts/gui/errordlg.m
patching file scripts/gui/helpdlg.m
patching file scripts/gui/module.mk
patching file scripts/gui/msgbox.m
patching file scripts/gui/warndlg.m
adding scripts/gui/__error-icon__.png
adding scripts/gui/__help-icon__.png
adding scripts/gui/__warn-icon__.png
committing files:
libgui/graphics/BaseControl.cc
libgui/src/octave-qt-link.cc
libgui/src/octave-qt-link.h
libinterp/corefcn/octave-link.cc
libinterp/corefcn/octave-link.h
scripts/gui/__error-icon__.png
scripts/gui/__help-icon__.png
scripts/gui/__warn-icon__.png
scripts/gui/errordlg.m
scripts/gui/helpdlg.m
scripts/gui/module.mk
scripts/gui/msgbox.m
scripts/gui/warndlg.m
committing manifest
committing changelog
now at: msgbox_fig4.patch
And all works as expected (including "demo msgbox")
I agree that reusing icons from the GUI for those dialogs would be cool but I
fear those icons are platform dependent (on my system, the icons are not those
shown here https://doc.qt.io/qt-5/qmessagebox.html#Icon-enum) and we would
need a way to fetch them at run time.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?42490>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Pantxo Diribarne, 2018/10/02
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Pantxo Diribarne, 2018/10/02
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Dan Sebald, 2018/10/03
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle,
Pantxo Diribarne <=
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Pantxo Diribarne, 2018/10/03
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Dan Sebald, 2018/10/03
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Pantxo Diribarne, 2018/10/03
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Pantxo Diribarne, 2018/10/03
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Pantxo Diribarne, 2018/10/03
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Dan Sebald, 2018/10/03
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Dan Sebald, 2018/10/03
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Pantxo Diribarne, 2018/10/03
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Pantxo Diribarne, 2018/10/05
- [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle, Dan Sebald, 2018/10/05