[Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle

[Pantxo Diribarne]

Follow-up Comment #21, bug #42490 (project octave):

@Dan: In this case windows an Mac users would have no icon at all. The
fallback mechanism I used is the one that is already in place and works very
well for all other icons. Basically it uses QIcon::fromTheme [1] which only
works on linux platform.

I am pretty sure that Qt uses native icons on Windows and Mac when displaying
a QMessageBox so that fallback icon we will get on those platforms won't match
the one we'll get when an actual QMessageBox is displayed. Yes I could extract
the icon from a QMessageBox in case none is returned, but honestly I have
recently worked on a patch that I couldn't really test myself (since I didn't
have a Mac) and I don't want to do this again, not now. So I'd be in favor of
leaving this as is and wait for complaints if any. 

[1] http://doc.qt.io/qt-5/qicon.html#fromTheme

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?42490>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/