[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55172] [octave forge] (image) b = bwmorph (BW

From: Hartmut
Subject: [Octave-bug-tracker] [bug #55172] [octave forge] (image) b = bwmorph (BW, 'thin', 1) is not Matlab compatible
Date: Sat, 8 Dec 2018 14:16:54 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0

Follow-up Comment #3, bug #55172 (project octave):

* I haven't tested the output values of your supposed function, yet. Have you?
Dou you get Matlab compatible results for a couple of meaningful examples? If
yes, could you add tests for those to bwmorph.m? (Do we need to remove
existing tests in bwmorph?)
* Could you add the content of your thin_fun1.m and thin_fun2.m somehow to the
existing private function __conditional_mark_patterns_lut_fun__ ? I like the
way this was done before: the final LUT numbers were hard-coded into the code
of bwmorph.m, but  there was also a (commented out) code line how to produce
this LUT via the __conditional_mark_patterns_lut_fun__ function. This made it
possible for me to understand where those numbers (the LUT) came from, and
imprived the maintainability of the code.
* Could you add the detailed paper reference into the code? (Maybe into
__conditional_mark_patterns_lut_fun__ .m?)


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]