[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #48774] Functions for moving statistics

From: Rik
Subject: [Octave-bug-tracker] [bug #48774] Functions for moving statistics
Date: Wed, 19 Dec 2018 12:55:04 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Edge/15.15063

Follow-up Comment #29, bug #48774 (project octave):

@Juan: Regarding programming strategies in core Octave, there is no simple
answer as to the best approach.  Octave should strike to have code which is
readable and maintainable, but it also needs to balance that with performance.
 The two goals are often in opposition.

If the only thing being implemented was a jump table then it would be fine to
use the original strategy.  But, the current function *does* require more
checking based on the type of Endpoint chosen.  For example, if the user
specifies a numeric fill value then one can't use [arg "_bc"] to construct a
valid function name so that is one special case.  Similarly, when the
"Endpoint" property is "discard" there is no actual discard_bc necessary, but
one does have to adjust various internal variables so that the correct length
output is generated.  Once several of the input values required identifying
and having different actions the dispatch table no longer made sense, at least
too me.

I'm not opposed if you want to re-work the input validation, as long as the
user-visible goals of functionality and performance are unchanged.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]