[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55306] non-english typing in the editor don't

From: Markus Mützel
Subject: [Octave-bug-tracker] [bug #55306] non-english typing in the editor don't appear but still there hidden causing error
Date: Mon, 31 Dec 2018 08:51:24 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Update of bug #55306 (project octave):

                  Status:               Need Info => None                   


Follow-up Comment #3:

The file still contains question mark characters where I think the arabic
characters should be.

I think I am able to duplicate something that is similar to what you see:

1. Set the encoding to something that doesn't encode the characters you want
to test with (e.g. ISO-8859-6 which doesn't contain umlauts).
2. Open a new editor tab and check that the encoding is used. Write some
characters that cannot be encoded (e.g. "test äöü").
3. Save that file.
4. Close the file in the editor and re-open. The non-encodable characters are
replaced by "?" (question mark).

That is confusing for a user because we don't give any indication that some of
the characters were lost when saving the file.

We should probably check if the editor content can be encoded correctly before
writing to the file.
This should probably be done in file_editor_tab::save_file
("libgui/src/m-editor/file-editor-tab.cc") before line 2157.
Calling "codec->canEncode (_edit_area->text ())" should de returning false in
this case.

Since I don't know how to add an appropriate user interface for this, I am
CC'ing Torsten. I hope you don't mind having a look at this.

I still don't know why these characters don't show up for you in the first
place. Might be a Scintilla bug. Or we are not setting it up correctly. [1]
might be related: "Scintilla only correctly displays bidirectional text on
some platforms."

[1]: https://www.scintilla.org/ScintillaDoc.html#SCI_SETBIDIRECTIONAL


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]