[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55741] build with '-Woverloaded-virtual' emit

From: John W. Eaton
Subject: [Octave-bug-tracker] [bug #55741] build with '-Woverloaded-virtual' emits many warnings indicating problems
Date: Wed, 20 Feb 2019 10:07:32 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Follow-up Comment #3, bug #55741 (project octave):

After thinking about this some more, I still agree that we should fix these to
avoid possible confusion.  But I don't think it's anything that needs to be
fixed immediately.  This warning is saying that a base class virtual function
is hidden by another function of the same name but different signature in the
derived class.  If these derived classes needed the base class function, we
would see an error about it not being available.  So it may be OK that they
are hidden.  But the overloaded names may also cause some future confusion. 
It depends on the details for each case.  So we shouldn't just go and add
public "using" declarations (or similar) in each of these derived classes
without first thinking about whether it is intentional that the base class
functions are hidden or whether there should be some other solution.  Maybe
some of them don't need to be virtual?


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]